httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Trawick" <traw...@gmail.com>
Subject Re: [PATCH 40026] ServerTokens Off
Date Mon, 14 Aug 2006 18:07:00 GMT
On 8/11/06, Sebastian Nohn <sebastian@nohn.net> wrote:

> And now patches against trunk are available too (attached to this mail).

A little more work is required.  With this trunk patch and
ServerTokens Off, this is logged
at startup:

[Mon Aug 14 13:54:19 2006] [notice]  configured -- resuming normal operations

By default:

[Mon Aug 14 13:53:45 2006] [notice] Apache/2.3.0-dev (Unix) DAV/2
configured -- resuming normal operations

The issue is that ap_get_server_version() is used for multiple uses:
a) a banner (for the lack of a better word) to be used on the wire
b) a string that tells the version of the server

What do folks think about the following change?

Rename existing ap_get_server_version() to ap_get_server_banner()

Change code that builds strings to send on the wire to call
ap_get_server_banner() instead.

ap_get_server_version() always spits out something like
"Apache/2.2.4-dev" (AP_SERVER_BASEVERSION AFAICT)

Mime
View raw message