httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sebastian Nohn <sebast...@nohn.net>
Subject Re: [PATCH] split ap_get_server_version() into two functions...
Date Thu, 31 Aug 2006 07:48:02 GMT
Sebastian Nohn wrote:
> Jeff Trawick wrote:
> 
>> ... so that ServerTokens doesn't affect what gets logged to the error
>> log at startup (or any other place where we want the description of
>> the server instead of the banner to be written over the network).
> 
> As far as I can see, your patch does not distinguish between those yet:
> 
> +AP_DECLARE(const char *) ap_get_server_description(void)
> +{
> +    return get_server_version();
> +}
> +
> +AP_DECLARE(const char *) ap_get_server_banner(void)
> +{
> +    return get_server_version();
> +}

Please find attached a patch that implements the desired behaviour in a
very rudimentary, but probably suffiecient manner (and includes my
ServerTokens Off patch, which could be removed easily but is included
for convenience).

Best regards,
  Sebastian Nohn
-- 
Sebastian Nohn · Wolfstraße 29 · 53111 Bonn · Germany
+49-228-4097103 · http://nohn.net/ · sebastian@nohn.net
http://pgpkeys.pca.dfn.de:11371/pks/lookup?op=get&fingerprint=on&search=0xD47D55E0

Mime
View raw message