httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sebastian Nohn <sebast...@nohn.net>
Subject Re: [PATCH 40026] ServerTokens Off
Date Thu, 31 Aug 2006 07:09:40 GMT
Jeff Trawick wrote:
> On 8/11/06, Sebastian Nohn <sebastian@nohn.net> wrote:
> 
>> And now patches against trunk are available too (attached to this mail).
> 
> A little more work is required.  With this trunk patch and

> Rename existing ap_get_server_version() to ap_get_server_banner()
> 
> Change code that builds strings to send on the wire to call
> ap_get_server_banner() instead.
> 
> ap_get_server_version() always spits out something like
> "Apache/2.2.4-dev" (AP_SERVER_BASEVERSION AFAICT)

Please find attached a patch which respects and includes your patch from
<cc67648e0608300618t5f133a85jc514a65009cbc359@mail.gmail.com>.

However, because your patch is not yet fully complete, as
ap_get_server_description() and ap_get_server_banner() both call
get_server_version(), this patch with ServerTokens Off still logs "" at
Server startup.

Best regards,
  Sebastian Nohn
-- 
Sebastian Nohn · Wolfstraße 29 · 53111 Bonn · Germany
+49-228-4097103 · http://nohn.net/ · sebastian@nohn.net
http://pgpkeys.pca.dfn.de:11371/pks/lookup?op=get&fingerprint=on&search=0xD47D55E0

Mime
View raw message