httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sebastian Nohn <sebast...@nohn.net>
Subject Re: [PATCH] split ap_get_server_version() into two functions...
Date Thu, 31 Aug 2006 07:03:09 GMT
Jeff Trawick wrote:

> ... so that ServerTokens doesn't affect what gets logged to the error
> log at startup (or any other place where we want the description of
> the server instead of the banner to be written over the network).

As far as I can see, your patch does not distinguish between those yet:

+AP_DECLARE(const char *) ap_get_server_description(void)
+{
+    return get_server_version();
+}
+
+AP_DECLARE(const char *) ap_get_server_banner(void)
+{
+    return get_server_version();
+}

> I haven't actually changed the returned strings with this patch, but
> instead would like to see any comments on the direction.  The two
> functions are present and all httpd code has been modified to call the

I should have read that ;)

> proper function, which is also subject to a useful review.  What about
> status pages?  Is the server version and module configuration somehow
> more private than the status page itself, such that they should use
> ap_get_server_banner() as in the current patch?

I don't think so. Someone who makes his status page public most likely
would also make his Server version and configured modules public. And
someone who protects his server status somehow does most likely not care
if Server version and module information is published on that page, so
in my opinion, the full information should be displayed on status pages.

Best regards,
  Sebastian Nohn
-- 
Sebastian Nohn · Wolfstraße 29 · 53111 Bonn · Germany
+49-228-4097103 · http://nohn.net/ · sebastian@nohn.net
http://pgpkeys.pca.dfn.de:11371/pks/lookup?op=get&fingerprint=on&search=0xD47D55E0

Mime
View raw message