httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject Re: DO NOT REPLY [Bug 40234] New: - failed request with APR_INCOMPLETE
Date Sat, 12 Aug 2006 03:54:41 GMT
Ruediger Pluem wrote:
>> Is this worth pursuing, or should we just apply the patch as-is?

Please don't.  Behavior is broken, but every time you patch this code I'm
another generation removed from my revetting and correction of the core
problems that exist.

> Provided that this does not break things on other platforms I would just
> apply the patch as-is.

Thanks, not?, that's partly what's gotten us into this mess.

For the moment, would you be so kind as to post the patch you believe solves
the entire crux of the issues in this function before committing?  Likewise,
I'll post what I come up with first to the list.

I'd love it if someone else thoroughly understood this convoluted mess,
that we are trying to simultaneously accomplish three or four things in
the most performant manner.  Clearer code would help (before you point
at me, try to grok the original 1.3 code before my time) - maybe it can
be further refactored for clarity.  But we need to axe some shortcuts that
are wrong, and if you grep for all the file_info calls, you will note that
we are horridly inconsistent at this point.

View raw message