httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: DO NOT REPLY [Bug 40234] New: - failed request with APR_INCOMPLETE
Date Fri, 11 Aug 2006 17:12:43 GMT
On Friday 11 August 2006 17:01, bugzilla@apache.org wrote:

> http://issues.apache.org/bugzilla/show_bug.cgi?id=40234
>
>            Summary: failed request with APR_INCOMPLETE
>            Product: Apache httpd-2
>            Version: 2.3-HEAD
> 
> On server/request.c(ap_directory_walk),
> call apr_stat with APR_FINFO_NAME.
>
> >            if (!(opts & OPT_SYM_LINKS)) {
> >                rv = apr_stat(&thisinfo, r->filename,
> >                              APR_FINFO_MIN | APR_FINFO_LINK,
> >                              r->pool);
> >                if (rv != APR_SUCCESS) {

This looks like a regression from the fixes to the symlinks+mod_dir problem:
http://svn.apache.org/viewvc/httpd/httpd/trunk/server/request.c?r1=420983&r2=425394

The reporter says the APR_FINFO_NAME is useless.  That looks right
to me (we're only checking if it's a symlink).  His patch makes sense on *X.

What about other platforms?  Well, AFAICT it'll work.  But it's also
irrelevant and could perhaps be optimised out?  It was only
added to fix a Unix bug!

Is this worth pursuing, or should we just apply the patch as-is?

-- 
Nick Kew

Mime
View raw message