Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 51821 invoked from network); 14 Jul 2006 14:42:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 14 Jul 2006 14:42:00 -0000 Received: (qmail 83732 invoked by uid 500); 14 Jul 2006 14:41:55 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 83664 invoked by uid 500); 14 Jul 2006 14:41:55 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 83653 invoked by uid 99); 14 Jul 2006 14:41:55 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jul 2006 07:41:55 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of rooneg@gmail.com designates 64.233.182.190 as permitted sender) Received: from [64.233.182.190] (HELO nf-out-0910.google.com) (64.233.182.190) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jul 2006 07:41:54 -0700 Received: by nf-out-0910.google.com with SMTP id y38so225548nfb for ; Fri, 14 Jul 2006 07:41:33 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=L01X0HYuyHKJwm4RM18RIH+YMXyZZYcMmHpv4cKZ3FSNOYBG9D+y1/dJ5hYVx3rLdxEoqlxWKq2Edq1n/OBrhzdSKOVX3xawWTlNjUizx3N1pXDZIOydH/zwp6zuAXYbzshh36/f9hub/OLI2mMgHfLEWa5NI3t62jrsNJThxwU= Received: by 10.78.116.19 with SMTP id o19mr1640910huc; Fri, 14 Jul 2006 07:41:33 -0700 (PDT) Received: by 10.78.97.11 with HTTP; Fri, 14 Jul 2006 07:41:33 -0700 (PDT) Message-ID: <7edfeeef0607140741v59f5d73tde747d6d23c9939d@mail.gmail.com> Date: Fri, 14 Jul 2006 10:41:33 -0400 From: "Garrett Rooney" Sender: rooneg@gmail.com To: dev@httpd.apache.org Subject: Re: svn commit: r421686 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_proxy.xml modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/proxy_util.c In-Reply-To: <200607141535.57144.nick@webthing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20060713190027.BF1F41A981D@eris.apache.org> <20060714131637.GA26556@redhat.com> <200607141535.57144.nick@webthing.com> X-Google-Sender-Auth: aee0c7e579b5d871 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 7/14/06, Nick Kew wrote: > On Friday 14 July 2006 14:16, Joe Orton wrote: > > > This introduced compiler warnings: > > > > cc1: warnings being treated as errors > > mod_proxy.c: In function `proxy_interpolate': > > mod_proxy.c:427: warning: passing arg 1 of `ap_strstr' discards qualifiers > > from pointer target type mod_proxy.c:431: warning: passing arg 1 of > > `ap_strchr' discards qualifiers from pointer target type make[4]: *** > > [mod_proxy.slo] Error 1 > > Ugh. > > It's being used in those lines with "const char*" arguments. > That's what the strstr and strchr take. Depending > on the AP_DEBUG setting, ap_strstr may be #defined to strstr > and ap_strchr to strchr. > > So the fact that that *can* generate those warnings looks like > an over-engineered and inconsistent httpd.h. You can avoid those warnings by using ap_strchr_c. -garrett