Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Message-ID: <44C3D7DD.4070605@rowe-clan.net>
Date: Sun, 23 Jul 2006 15:11:09 -0500
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
User-Agent: Thunderbird 1.5.0.4 (X11/20060614)
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: svn commit: r424584 - in /httpd/httpd/branches/2.2.x/modules/ssl:
 mod_ssl.c ssl_engine_config.c ssl_engine_init.c ssl_engine_pphrase.c
 ssl_private.h
 ssl_util.c
References: <20060722142745.A05B51A981A@eris.apache.org>
 <20060723093125.GA19423@redhat.com> <44C36728.7050903@algroup.co.uk>
 <44C374E4.7020002@apache.org> <44C3B7D9.7050201@algroup.co.uk>
In-Reply-To: <44C3B7D9.7050201@algroup.co.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Ben Laurie wrote:
> Ruediger Pluem wrote:
>> On 07/23/2006 02:10 PM, Ben Laurie wrote:
>>>>
>>>> [Sun Jul 23 10:25:14 2006] [info] Loading certificate & private key of SSL-aware server
>>>> [Sun Jul 23 10:25:14 2006] [error] Can't open \x80\x94|
>>> Hmmm. Can't reproduce this (on the trunk).
>> This is pure luck. You should init pkcs7 to NULL in modssl_ctx_init as done for the other
>> elements of this struct.
> 
> Sure. You are allowed to just commit the fix, you know?

Uhm - he probably would have if the code was on trunk/ ;-)

Be careful in dir_config/server_config structures and watch if they have
been apr_palloc'ed or apr_pcalloc'ed() - ensuring you a default NULL.

We typically apr_pcalloc() if almost every conf member should start 0/null,
while we typically apr_palloc() if most members will have interesting default
values from the start, or non-0 undefined values.