httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r424584 - in /httpd/httpd/branches/2.2.x/modules/ssl: mod_ssl.c ssl_engine_config.c ssl_engine_init.c ssl_engine_pphrase.c ssl_private.h ssl_util.c
Date Sun, 23 Jul 2006 20:11:09 GMT
Ben Laurie wrote:
> Ruediger Pluem wrote:
>> On 07/23/2006 02:10 PM, Ben Laurie wrote:
>>>>
>>>> [Sun Jul 23 10:25:14 2006] [info] Loading certificate & private key of
SSL-aware server
>>>> [Sun Jul 23 10:25:14 2006] [error] Can't open \x80\x94|
>>> Hmmm. Can't reproduce this (on the trunk).
>> This is pure luck. You should init pkcs7 to NULL in modssl_ctx_init as done for the
other
>> elements of this struct.
> 
> Sure. You are allowed to just commit the fix, you know?

Uhm - he probably would have if the code was on trunk/ ;-)

Be careful in dir_config/server_config structures and watch if they have
been apr_palloc'ed or apr_pcalloc'ed() - ensuring you a default NULL.

We typically apr_pcalloc() if almost every conf member should start 0/null,
while we typically apr_palloc() if most members will have interesting default
values from the start, or non-0 undefined values.

Mime
View raw message