httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: svn commit: r424584 - in /httpd/httpd/branches/2.2.x/modules/ssl: mod_ssl.c ssl_engine_config.c ssl_engine_init.c ssl_engine_pphrase.c ssl_private.h ssl_util.c
Date Sun, 23 Jul 2006 12:10:16 GMT
Joe Orton wrote:
> On Sat, Jul 22, 2006 at 02:27:44PM -0000, ben@apache.org wrote:
>> Author: ben
>> Date: Sat Jul 22 07:27:43 2006
>> New Revision: 424584
>>
>> URL: http://svn.apache.org/viewvc?rev=424584&view=rev
>> Log:
>> Add PKCS#7 support.
> 
> -1.  We've had an RTC policy on the stable branch for many years: please 
> revert and try again on the trunk, then propose a backport.

Sure thing.

> - fix the code style: spaces not tabs, spaces after commas, etc etc

OK, I may have slipped up a couple of times, but what is "etc etc"?

> - use APR apr_file_* not ANSI C fopen,

I need a FILE *.

> and close files after you use 
> them

Ooops.

> - the server doesn't even start up (without the new stuff configured):
> 
> [Sun Jul 23 10:25:14 2006] [info] Loading certificate & private key of SSL-aware
server
> [Sun Jul 23 10:25:14 2006] [error] Can't open \x80\x94|

Hmmm. Can't reproduce this (on the trunk).

> - fix the compiler warning (and perhaps hence the above):
> 
> ssl_util.c: In function 'ssl_read_pkcs7':
> ssl_util.c:271: warning: 'certs' may be used uninitialized in this function

This won't fix the above. certs is actually only uninitialized if death
is about to occur.

> 
> joe
> 
> 


-- 
http://www.apache-ssl.org/ben.html           http://www.links.org/

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff

Mime
View raw message