httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r422298 - in /httpd/httpd/trunk/support: ./ Makefile.in
Date Mon, 17 Jul 2006 14:04:24 GMT
Joe Orton wrote:
> On Sun, Jul 16, 2006 at 12:22:32AM +0200, André Malo wrote:
>> * pquerna@apache.org wrote:
>>
>>> Modified: httpd/httpd/trunk/support/Makefile.in
>>> +ifneq (win32,${OS})
>>> +  PROGRAMS += checkgid fcgistarter
>>> +endif
>>> +
>> I'm not a Makefile guru, but that doesn't look really portable (or do we 
>> require a particular make version?). I'd think anyway, that such stuff 
>> should be done by configure (but I've got not much fu there either...)
> 
> It's not, ifneq is a GNU make extension; yes, it needs to be done in 
> configure.

Aside from which, it seems silly (after a pass through configure) to make
deterministic choices like this at make time :)

Mime
View raw message