Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: domain of jorton@redhat.com designates
 66.187.233.31 as permitted sender)
Date: Wed, 14 Jun 2006 13:12:09 +0100
From: Joe Orton <jorton@redhat.com>
To: dev@httpd.apache.org
Subject: Re: svn commit: r413861 - /httpd/httpd/trunk/support/ab.c
Message-ID: <20060614121209.GD25292@redhat.com>
Mail-Followup-To: dev@httpd.apache.org
References: <20060613105155.E55FA1A983A@eris.apache.org>
 <20060613111138.GA1109@redhat.com> <20060613112820.GA7690@dochas.stdlib.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20060613112820.GA7690@dochas.stdlib.net>
User-Agent: Mutt/1.4.2.1i

On Tue, Jun 13, 2006 at 12:28:20PM +0100, Colm MacCarthaigh wrote:
> On Tue, Jun 13, 2006 at 12:11:38PM +0100, Joe Orton wrote:
> > On Tue, Jun 13, 2006 at 10:51:55AM -0000, colm@apache.org wrote:
> > > Author: colm
> > > Date: Tue Jun 13 03:51:54 2006
> > > New Revision: 413861
> > > 
> > > URL: http://svn.apache.org/viewvc?rev=413861&view=rev
> > > Log:
> > > A keepalive response need not neccessarily have included any content-length
> > > header, handle this case properly for 304 responses. PR39789
> > 
> > This looks wrong, the patch in the PR was a bit better.  If a response 
> > doesn't have a C-L/T-E the body is read till EOF.  [23]04 are special 
> > cases which have zero length bodies regardless of the message headers.
> 
> 204 is why I didn't conditionalise it on 304, my comment was a bit
> misleading there. My change has the same effect as the patch in the PR
> for 304 responses, but also for any other keep-alive request which
> doesn't include a C-L. Should I restrict to more specific response
> codes? or is there another problem I'm just not seeing :)

Oh sorry, I missed that this is localised to the "keep-alive" case; in 
that case I guess it is no less dubious than the rest of the ab response 
parsing, I don't think it'll break with any normal server.

joe