Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: domain of jorton@redhat.com designates
 66.187.233.31 as permitted sender)
Date: Thu, 1 Jun 2006 10:31:47 +0100
From: Joe Orton <jorton@redhat.com>
To: dev@httpd.apache.org
Subject: Re: svn commit: r395211 - /httpd/httpd/trunk/configure.in
Message-ID: <20060601093147.GF15356@redhat.com>
Mail-Followup-To: dev@httpd.apache.org
References: <20060419105733.4825.qmail@minotaur.apache.org>
 <4475FF18.6040907@apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4475FF18.6040907@apache.org>
User-Agent: Mutt/1.4.2.1i

On Thu, May 25, 2006 at 09:01:44PM +0200, Ruediger Pluem wrote:
> On 04/19/2006 12:57 PM,
> > Author: jorton
> > Date: Wed Apr 19 03:57:20 2006
> > New Revision: 395211
...
> > +if test "x$with_included_apr" = "xyes"; then
> > +   apr_found=reconfig
> > +   apr_config="$srcdir/srclib/apr/apr-1-config"
> > +else 
> 
> Is it really a good idea to hardcode apr-1-config or shouldn't it be something like
> apr-?-config (Same question for apu-1-config below)?

The "1" requirement is hardcoded in the APR_FIND_APx calls anyway, so I 
don't think this is a big deal.  They could all be replaced with some 
variable I suppose.

> > +if test "x$with_included_apr" = "xyes"; then
> > +   apu_found=reconfig
> > +   apu_config="${srcdir}/srclib/apr-util/apu-1-config"
> > +else 
> > +   APR_FIND_APU("$srcdir/srclib/apr-util", "./srclib/apr-util", 1, 1)
> > +fi

joe