httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r416265 - in /httpd/httpd/trunk/modules/ssl: mod_ssl.c ssl_engine_config.c ssl_engine_io.c ssl_private.h
Date Thu, 22 Jun 2006 09:59:58 GMT
Joe Orton wrote:
>> @@ -1793,7 +1798,7 @@
>>                      rc, argi, (cmd == (BIO_CB_WRITE|BIO_CB_RETURN) ? "to" : "from"),
>>                      bio, argp,
>>                      (argp != NULL ? "(BIO dump follows)" : "(Oops, no memory buffer?)"));
>> -            if (argp != NULL)
>> +            if ((argp != NULL) && (sc->ssl_log_level >= SSL_LOG_BYTES))
>>                  ssl_io_data_dump(s, argp, rc);
> 
> Looks like the debug message above needs to be adjusted for this, it's 
> going to say "BIO dump follows" when no BIO dump will follow (in the 
> default config)?

Yup, note that argp != null was the old condition to both.  (Well, the exception
case text doesn't apply to us ;-)   But you are right, this would be more sane,
additional commits and feedback are welcome, I'm really counting minutes now
trying to get ready to ship off to IE.

Bill

Mime
View raw message