Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: domain of jfclere@gmail.com designates
 64.233.182.184 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:user-agent:x-accept-language:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding;
        b=jPuLZSpzm2VPAtaA3pybMogWT09vPCpNEHnvt9GrOVj9q03lVm5jLBrj1/Tn46MvfNMqb3i2m/Wy7hj73pElceGRYQx3R8j0uoDr7wSsBdUls4CTuNSEnCkln6Dm6WoxkxWVx1Tle9Z8HrZvXig6VvNu3phSxZWsdfdoIyXqnmY=
Message-ID: <446972F3.5040601@gmail.com>
Date: Tue, 16 May 2006 08:36:35 +0200
From: Jean-frederic Clere <jfclere@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060417
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: [PATCH 1/6] scoreboard over-sized
References: <445A3739.7080406@pearsoncmg.com> <44632CEC.7030905@gmail.com>
 <44648E36.5040102@pearsoncmg.com>
In-Reply-To: <44648E36.5040102@pearsoncmg.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Chris Darroch wrote:

>Jean-frederic Clere wrote:
>
>  
>
>>BTW: lb_scrore has a size of 1024 and proxy_worker_stat 176...
>>I am thinking in using this not yet used space.
>>    
>>
>
>   You're referring to ap_proxy_initialize_worker_share() in
>proxy_util.c, I take it?  It seems to be the only user of the
>1024 byte array in lb_score and fills it with proxy_worker_stat
>structures.
>  
>
Yes that is what I am refering to.

>   For a private module, you could of course use the extra space;
>it's your call.  The comments in scoreboard.h about the 1024 byte
>array ("TODO: make a real stuct from this") make it fairly clear
>that you shouldn't assume that array is a permanent feature, though.
>
>   Personally, if I was writing a completely private module, I'd
>probably just patch the scoreboard.h definition of lb_score to include
>whatever extra stuff I needed, and recompile httpd.  That way I'm
>insulated from any changes to the size of either the array or the
>proxy_worker_stat structure; if they change at some point in a
>future release and I don't happen to notice, I'm safe so long as
>I keep patching in my extra fields.
>  
>
Ok.

>   Now, if you're thinking instead of contributing a public patch
>to httpd, then I think that you'd definitely want to avoid just
>using more of the array -- it's a small hack now, but adding to
>it will only make it harder to tidy up later.  Better to add
>some fields to lb_score so that people can understand what's going
>on with your stuff.  That's just IMHO, of course.
>
>Chris.
>
>  
>