httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm MacCarthaigh <c...@stdlib.net>
Subject Re: svn commit: r409942 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_disk_cache.c
Date Sun, 28 May 2006 12:33:25 GMT
On Sun, May 28, 2006 at 10:32:04AM -0000, rpluem@apache.org wrote:
>          rv = apr_file_rename(dobj->tempfile, dobj->datafile, r->pool);
>          if (rv != APR_SUCCESS) {
> -            /* XXX log */
> +            ap_log_error(APLOG_MARK, APLOG_DEBUG, rv, r->server,
> +                         "disk_cache: rename tempfile to datafile failed:"
> +                         " %s -> %s", dobj->tempfile, dobj->datafile);
> +            apr_file_remove(dobj->tempfile, r->pool);
>          }

A significant source of this kind of error is that the filesystem
suddenly becomes read-only. Either to a protective automative re-mount
by the kernel, a log journal becoming full, in which case the remove
will also fail :/

-- 
Colm MacCárthaigh                        Public Key: colm+pgp@stdlib.net

Mime
View raw message