httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: [PATCH 4/6] fork() failure handling
Date Sun, 07 May 2006 20:46:24 GMT
On Thursday 04 May 2006 18:48, Chris Darroch wrote:

> -        /* fork didn't succeed. Fix the scoreboard or else
> -         * it will say SERVER_STARTING forever and ever
> +        /* fork didn't succeed.  There's no need to touch the scoreboard;
> +         * if we were trying to replace a failed child process, then
> +         * server_main_loop() marked its workers SERVER_DEAD, and if
> +         * we were trying to replace a child process that exited normally,
> +         * its worker_thread()s left SERVER_DEAD or SERVER_GRACEFUL
> behind. */
> -        ap_update_child_status_from_indexes(slot, 0, SERVER_DEAD, NULL);

That makes sense, and doesn't seem to break anything.  Basically you're
saying there's a mismatch between a process-level failure and setting
a thread-level slot.  So why was it there in the first place?


-- 
Nick Kew

Mime
View raw message