httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: r382799 - /httpd/httpd/trunk/modules/ssl/ssl_scache_shmcb.c
Date Wed, 03 May 2006 13:20:41 GMT
On Sun, Mar 05, 2006 at 01:21:08AM -0500, Geoff Thorpe wrote:
> On March 3, 2006 08:11 am, Joe Orton wrote:
> [snip]
> > Log:
> > * modules/ssl/ssl_scache_shmcb.c (shmcb_safe_clear): Mark with
> > "noinline" attribute for GCC > 3.
> [snip]
> 
> This reminded me that I had a rewrite of shmcb lurking around that needed 
> dusting off and updating due to changes in CVS. I've attached a new 
> version that is a drop-in replacement for 2.2.0 - I think it addresses 
> all the "safe" memcpy issues and would *finally* allow Ken Coar to remove 
> that shmcb item from STATUS. It also obviates the need for the gcc-fear 
> your commit aptly illustrated :-) (The new version is no longer 
> vulnerable to agressive memset optimisation - the only memsets should be 
> for binary data).

Geoff - sorry for the ultra-slow response.  This looks great, much 
simpler code to follow.  I've committed this to the trunk with a few 
minor tweaks:

http://svn.apache.org/viewcvs.cgi?rev=399291&view=rev

Thanks a lot!

joe

Mime
View raw message