httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Trawick" <traw...@gmail.com>
Subject Re: svn commit: r393868 - in /httpd/httpd/trunk/server/mpm: experimental/event/event.c worker/worker.c
Date Thu, 13 Apr 2006 18:42:56 GMT
On 4/13/06, gregames@apache.org <gregames@apache.org> wrote:
> Author: gregames
> Date: Thu Apr 13 10:53:04 2006
> New Revision: 393868
>
> URL: http://svn.apache.org/viewcvs?rev=393868&view=rev
> Log:
> MaxClients isn't the only reason the scoreboard can fill up.  another
> reason should be fixed soon.

>              if (!reported) {
> -                ap_log_error(APLOG_MARK, APLOG_ERR, 0,
> -                             ap_server_conf,
> -                             "server reached MaxClients setting, consider"
> -                             " raising the MaxClients setting");
> +                if (active_thread_count >=
> +                        ap_daemons_limit * ap_threads_per_child) {
> +                    ap_log_error(APLOG_MARK, APLOG_ERR, 0,
> +                                 ap_server_conf,
> +                                 "server reached MaxClients setting, consider"
> +                                 " raising the MaxClients setting");
> +                }
> +                else {
> +                    ap_log_error(APLOG_MARK, APLOG_ERR, 0,
> +                                 ap_server_conf,
> +                                 "scoreboard is full, not at MaxClients");
> +                }
>                  reported = 1;

Plz confirm...

After a fix to prevent the fork bomb during slow child startup is
applied, something REALLY strange and completely unanticipated has to
happen to get the "scoreboard is full, not at MaxClients" message. 
True?  Otherwise, seeing one of these messages shouldn't prevent us
from ever seeing the other.

>From a user support perspective, it is very handy to be able to have
the user grep for "server reached MaxClients" to rule out a particular
type of issue, without worrying if some odd temporary situation hid
that message forever.

Mime
View raw message