httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Garrett Rooney" <roo...@electricjellyfish.net>
Subject Re: svn commit: r391080 - in /httpd/mod_smtpd/trunk/src: Makefile.am smtp_bouncer.c smtp_protocol.c smtp_util.c
Date Mon, 03 Apr 2006 16:59:23 GMT
On 4/3/06, rian@apache.org <rian@apache.org> wrote:

> --- httpd/mod_smtpd/trunk/src/smtp_util.c (original)
> +++ httpd/mod_smtpd/trunk/src/smtp_util.c Mon Apr  3 09:40:17 2006
> @@ -76,15 +76,17 @@
>      smtpd_run_on_reset_envelope(scr);
>      smtpd_clear_envelope_rec(scr);
>  }
> -
> +#if 0
>  #include <netinet/in.h>
>  #include <arpa/nameser.h>
>  #include <resolv.h>
> +#endif
>
>  SMTPD_DECLARE_NONSTD(apr_status_t)
>  smtpd_get_mailex(apr_pool_t *pool, /* out */ char **resolved_host,
>                   char *original_host)
>  {
> +#if 0
>      /* res_search hack, too dependent */
>      unsigned char buf[NS_PACKETSZ];
>      ns_msg handle;
> @@ -130,6 +132,8 @@
>                         ns_rr_rdata(rr) + 2,
>                         *resolved_host,
>                         MAXDNAME);
> +#endif
> +    *resolved_host = apr_pstrdup(pool, original_host);
>
>      return APR_SUCCESS;
>  }

If you must #if 0 out code like this, at least leave some indication
of why it's been done.  Ideally though, I'd suggest just removing it,
you can always get it back from the subversion repository if you need
it again later.

-garrett

Mime
View raw message