From dev-return-52446-apmail-httpd-dev-archive=httpd.apache.org@httpd.apache.org Fri Mar 17 16:59:48 2006 Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 39180 invoked from network); 17 Mar 2006 16:59:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 17 Mar 2006 16:59:45 -0000 Received: (qmail 45337 invoked by uid 500); 17 Mar 2006 16:59:39 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 45285 invoked by uid 500); 17 Mar 2006 16:59:39 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 45274 invoked by uid 99); 17 Mar 2006 16:59:38 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Mar 2006 08:59:38 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [204.11.219.142] (HELO lt4.firehawksystems.com) (204.11.219.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Mar 2006 08:59:38 -0800 Received: from [10.0.0.2] ([69.219.226.176]) (authenticated bits=0) by lt4.firehawksystems.com (8.13.5/8.13.3) with ESMTP id k2HACLKL037897 for ; Fri, 17 Mar 2006 10:12:22 GMT Mime-Version: 1.0 (Apple Message framework v746.3) In-Reply-To: <200603171643.51750.nick@webthing.com> References: <9C3EAE20-ED81-4966-8494-4BC1E7ED7924@firehawksystems.com> <200603171643.51750.nick@webthing.com> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <986261EE-E50D-4E9E-BB32-EFD604673907@firehawksystems.com> Content-Transfer-Encoding: 7bit From: "Brian J. France" Subject: Re: mod_dbd crash Date: Fri, 17 Mar 2006 11:59:14 -0500 To: dev@httpd.apache.org X-Mailer: Apple Mail (2.746.3) X-Virus-Scanned: ClamAV version 0.88, clamav-milter version 0.87 on lt4.firehawksystems.com X-Virus-Status: Clean X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on lt4.firehawksystems.com X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.1.0 X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On Mar 17, 2006, at 11:42 AM, Nick Kew wrote: > On Friday 17 March 2006 16:03, Brian J. France wrote: >> Here is a patch to mod_dbd.c and mod_authn_dbd.c (not sure if >> anything else uses that function) that returns a status code: >> >> http://www.brianfrance.com/software/apache/2006.03.17.diff > > Thanks. This patch is a change to the API/ABI, but since it's just a > void --> apr_status_t return value, it won't break anything. Please tweak the patch as needed, this was just a 5 min hack to show what I was thinking. Paul pointed out on IRC it should return an defined error instead of -1, so may be apr_status_t isn't the best fix. > Not sure if that's allowed within 2.2.x. In that case may be add some code to print an error and then abort, since it is going to crash anyways. Brian