httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, VIS <>
Subject Re: AW: svn commit: r389697 - /httpd/httpd/trunk/modules/cache/mod_disk_cache.c
Date Wed, 29 Mar 2006 15:17:36 GMT

> -----Ursprüngliche Nachricht-----
> Von: Jim Jagielski 
> > 
> That seem to be the case when we have a general error. In other
> places where we have a valid 'rv', we tend to return that.
> Look at file_cache_recall_mydata() for example...
> In the above, I think the return status may be useful, so
> we shouldn't mask it, imo.

As said I am fine with either way, but currently we also return
APR_EGENERAL if apr_file_write_full fails below. So we should return
in this case rv too.



View raw message