httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <bnicho...@novell.com>
Subject Re: svn commit: r386477 - /httpd/httpd/trunk/modules/ldap/util_ldap.c
Date Fri, 17 Mar 2006 03:58:15 GMT
>>> On 3/16/2006 at 7:01 pm, in message
<cc67648e0603161801m57a39826l822e111cf7fde09a@mail.gmail.com>, "Jeff
Trawick"
<trawick@gmail.com> wrote:
> On 3/16/06, bnicholes@apache.org <bnicholes@apache.org> wrote:
> 
>> URL: http://svn.apache.org/viewcvs?rev=386477&view=rev 
>> Log:
>> remove the race condition when creating the connection pool mutex. 
Also 
> eliminate some unnecessary uses of the global memory pool
> 
> cool!
> 
>> @@ -1753,7 +1753,10 @@
>>      util_ldap_state_t *base = (util_ldap_state_t *) basev;
>>      util_ldap_state_t *overrides = (util_ldap_state_t *)
overridesv;
>>
>> -    st->pool = p;
>> +    st->pool = base->pool;
>> +#if APR_HAS_THREADS
>> +    st->mutex = base->mutex;
>> +#endif
> 
> What this use of the base pool and mutex means is that while a
subpool
> and mutex were created for the vhost, we'll never use them. 
Instead,
> we'll use the subpool and mutex created for the main server.
> 
> Not what you meant, right

I guess I don't understand.  When I tested this using the worker MPM (3
servers, 25 threads each) and configuring both an ldap protected
directory in the main server and an ldap protected directory in a vhost,
it never had a problem locking the mutex or allocating memory.   Am I
missing something?

Brad

Mime
View raw message