httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: mod_deflate and internal redirects
Date Fri, 31 Mar 2006 17:16:21 GMT
Brian Akins wrote:
> 
> Brian J. France wrote:
> 
> > r->main will be NULL, but r->prev is valid for internal redirects.  This 
> > was talked about on IRC and Brian Akins mentioned creating a 
> > ap_is_subrequest call:
> > 
> >   #define ap_is_subrequest(r) (r->main != NULL)
> I think we decided against that and just have mod_deflate changed to:
> 
> if(r->main != NULL) {
> 

If the question is whether to avoid using a macro, then
I'm +1 (the test is a well known documented feature).
If the question is whether or not it's the right
fix, I'm 0 

-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
	    "If you can dodge a wrench, you can dodge a ball."

Mime
View raw message