httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: AW: svn commit: r389697 - /httpd/httpd/trunk/modules/cache/mod_disk_cache.c
Date Wed, 29 Mar 2006 14:50:54 GMT
=?iso-8859-1?Q?Pl=FCm=2C_R=FCdiger=2C_VIS?= wrote:
> 
> 
> 
> > -----Urspr=FCngliche Nachricht-----
> > Von: Jim Jagielski=20
> >=20
> 
> > > +            file_cache_errorcleanup(dobj, r);
> > > +            return APR_EGENERAL;
> > > +        }
> >=20
> > Why don't we return rv ?
> 
> Because we also return APR_EGENERAL in the cases below. I think the =
> behaviour
> should be consistent. So if we think that returning rv is better we =
> should
> also do this below. I am fine with either decision.
> 

That seem to be the case when we have a general error. In other
places where we have a valid 'rv', we tend to return that.
Look at file_cache_recall_mydata() for example...

In the above, I think the return status may be useful, so
we shouldn't mask it, imo.

-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
	    "If you can dodge a wrench, you can dodge a ball."

Mime
View raw message