httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r389697 - /httpd/httpd/trunk/modules/cache/mod_disk_cache.c
Date Wed, 29 Mar 2006 13:52:17 GMT
rpluem@apache.org wrote:
> 
> --- httpd/httpd/trunk/modules/cache/mod_disk_cache.c (original)
> +++ httpd/httpd/trunk/modules/cache/mod_disk_cache.c Tue Mar 28 22:53:51 2006
> @@ -984,7 +984,15 @@
>      {
>          const char *str;
>          apr_size_t length, written;
> -        apr_bucket_read(e, &str, &length, APR_BLOCK_READ);
> +        rv = apr_bucket_read(e, &str, &length, APR_BLOCK_READ);
> +        if (rv != APR_SUCCESS) {
> +            ap_log_error(APLOG_MARK, APLOG_ERR, 0, r->server,
> +                         "cache_disk: Error when reading bucket for URL %s",
> +                         h->cache_obj->key);
> +            /* Remove the intermediate cache file and return non-APR_SUCCESS */
> +            file_cache_errorcleanup(dobj, r);
> +            return APR_EGENERAL;
> +        }

Why don't we return rv ?

-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
	    "If you can dodge a wrench, you can dodge a ball."

Mime
View raw message