httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r374908 - /httpd/httpd/branches/2.2.x/STATUS
Date Mon, 06 Feb 2006 23:52:50 GMT
Ping jorton,

you -0'ed the proposed patch below, with a suggested improvement.  I have
not seen your comments yet on the adjustment to address your concern, which
I committed a week or two ago.

What's your current vote?  Opinions from anyone else?

Bill

> --- httpd/httpd/branches/2.2.x/STATUS (original)
> +++ httpd/httpd/branches/2.2.x/STATUS Sat Feb  4 11:05:53 2006
> @@ -150,11 +150,12 @@
>  
>      * Fix mis-shifted 32 bit scope, masked to 64 bits as a method.
>          URL: http://svn.apache.org/viewcvs?rev=358040&view=rev
> -      +1: wrowe, mturk
> +      +1: mturk
>        -0: jorton: should use AP_METHOD_BIT
>            wrowe asks; is this your desired patch?  Please vote;
>  -        if (! (reqs[x].method_mask & (1 << m))) {
>  +        if (! (reqs[x].method_mask & (AP_METHOD_BIT << m))) {
> +      +1: wrowe  (for flavor requested by jorton)

Mime
View raw message