Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 48434 invoked from network); 13 Jan 2006 21:45:33 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 13 Jan 2006 21:45:33 -0000 Received: (qmail 13277 invoked by uid 500); 13 Jan 2006 21:45:28 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 13224 invoked by uid 500); 13 Jan 2006 21:45:28 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 13212 invoked by uid 99); 13 Jan 2006 21:45:28 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jan 2006 13:45:28 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [192.94.73.21] (HELO sdf.lonestar.org) (192.94.73.21) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jan 2006 13:45:26 -0800 Received: from sdf.lonestar.org (IDENT:alexeyt@ukato.freeshell.org [192.94.73.7]) by sdf.lonestar.org (8.13.1/8.12.10) with ESMTP id k0DLivFe010419 for ; Fri, 13 Jan 2006 21:44:57 GMT Received: (from alexeyt@localhost) by sdf.lonestar.org (8.13.1/8.12.8/Submit) id k0DLivHZ029599; Fri, 13 Jan 2006 21:44:57 GMT Date: Fri, 13 Jan 2006 21:44:57 +0000 (UTC) From: Alexey Toptygin To: dev@httpd.apache.org Subject: module loading code Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N I've been reading the module loading code, and I must ask: why are there still 2 module lists (ap_top_module and ap_loaded_modules) in 2.2? Since AddModule went away in 2.0.11, I can understand keeping them both for binary compat in 2.0, but are they needed now? Can the autogenerated ap_prelinked_modules and ap_preloaded_modules ever turn out different any more? Does it matter, considering ap_add_named_module is gone so nothing on the prelinked list can ever be promoted to the active list? AFAICT, it should be possible to remove ap_top_module, and change its users to iterate over ap_loaded_modules; and remove ap_prelinked_modules; and simplify all of the add/remove/init modules logic, since it doesn't need to keep 2 lists any more. Is this a good idea? Am I missing something? Anyway, the references to AddModule in build/build-modules-c.awk and modules/mapper/mod_so.c should probably go away. Alexey