Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Errors-To: <wrowe@rowe-clan.net>
Message-ID: <43BF80CF.80209@rowe-clan.net>
Date: Sat, 07 Jan 2006 02:50:23 -0600
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc3 (X11/20050929)
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: svn commit: r366174 -
 /httpd/mod_mbox/trunk/module-2.0/mod_mbox_mime.c
References: <20060105124954.52862.qmail@minotaur.apache.org>
 <22271E5C-AF52-4EB1-AB77-9B5B5FF10990@gbiv.com>
In-Reply-To: <22271E5C-AF52-4EB1-AB77-9B5B5FF10990@gbiv.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Roy T. Fielding wrote:
> On Jan 5, 2006, at 4:49 AM, maxime@apache.org wrote:
> 
>> +     In order to handle empty boundaries, we'll look for the
>> +     boundary plus the \n. */
>> +
>> +    boundary_line = apr_pstrcat(p, "--", mail->boundary, "\n", NULL);
>>
>>      /* The start boundary */
>> -    bound = ap_strstr(mail->body, mail->boundary);
>> +    bound = ap_strstr(mail->body, boundary_line);
> 
> That seems a bit risky -- MIME parts are supposed to have CRLF for
> line terminators, but that code will only search for LF on Unix.
> 
> Would it make more sense to use a regex?

Why not

+    boundary_line = apr_pstrcat(p, "--", mail->boundary, "\r\n", NULL);

which should be far faster than a regex evaluation?