httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: AW: AW: AW: 2.2 mod_http_proxy and "partial" pages
Date Fri, 06 Jan 2006 19:03:08 GMT

On Jan 6, 2006, at 1:47 PM, Jim Jagielski wrote:

> Still not sure why you are using a specific error detection
> filter rather than the generic one in -trunk
>
> On Jan 5, 2006, at 2:59 PM, Ruediger Pluem wrote:
>
>> @@ -146,13 +162,20 @@
>>           *   2) the trailer
>>           *   3) the end-of-chunked body CRLF
>>           *
>> -         * If there is no EOS bucket, then do nothing.
>> +         * If there is no EOS bucket, or if we had seen an error  
>> bucket with
>> +         * status HTTP_BAD_GATEWAY then do nothing. We have  
>> memorized an
>> +         * error bucket that we had seen in the filter context.
>> +         * The error bucket with status HTTP_BAD_GATEWAY  
>> indicates that the
>> +         * connection to the backend (mod_proxy) broke in the  
>> middle of the
>> +         * response. In order to signal the client that something  
>> went wrong
>> +         * we do not create the last-chunk marker and set c- 
>> >keepalive to
>> +         * AP_CONN_CLOSE in the core output filter.
>>           *
>>           * XXX: it would be nice to combine this with the end-of- 
>> chunk
>>           * marker above, but this is a bit more straight-forward for
>>           * now.
>>           */
>> -        if (eos != NULL) {
>> +        if (eos && !f->ctx) {
>
> Code logic doesn't match comment.
>

I should clarify that: when the comment says "or" yet the
code does an "and" then it causes undue confusion, even
if the 2 do sync up. 

Mime
View raw message