Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 37317 invoked from network); 6 Dec 2005 19:20:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 6 Dec 2005 19:20:15 -0000 Received: (qmail 9140 invoked by uid 500); 6 Dec 2005 19:20:10 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 9075 invoked by uid 500); 6 Dec 2005 19:20:10 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 9063 invoked by uid 99); 6 Dec 2005 19:20:09 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2005 11:20:09 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of apache-dev@m.gmane.org designates 80.91.229.2 as permitted sender) Received: from [80.91.229.2] (HELO ciao.gmane.org) (80.91.229.2) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2005 11:20:09 -0800 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1EjiKE-00039V-J9 for dev@httpd.apache.org; Tue, 06 Dec 2005 20:18:06 +0100 Received: from aorleans-154-1-10-246.w86-195.abo.wanadoo.fr ([86.195.73.246]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 06 Dec 2005 20:18:06 +0100 Received: from christophe.jaillet by aorleans-154-1-10-246.w86-195.abo.wanadoo.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 06 Dec 2005 20:18:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: dev@httpd.apache.org From: "Christophe Jaillet" Subject: [Patch] cleanup in 'modules/aaa/mod_authnz_ldap.c' Date: Tue, 6 Dec 2005 20:13:27 +0100 Lines: 31 Message-ID: X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: aorleans-154-1-10-246.w86-195.abo.wanadoo.fr X-MSMail-Priority: Normal X-Newsreader: Microsoft Outlook Express 6.00.2800.1506 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1506 Sender: news X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi, a few weeks ago I noticed that 'modules/aaa/mod_authnz_ldap.c' could be cleaned up a little. Now here is the patch. Regards, CJ Index: modules/aaa/mod_authnz_ldap.c =================================================================== --- modules/aaa/mod_authnz_ldap.c (révision 354496) +++ modules/aaa/mod_authnz_ldap.c (copie de travail) @@ -864,11 +864,7 @@ /* Set all the values, or at least some sane defaults */ if (sec->host) { - char *p = apr_palloc(cmd->pool, strlen(sec->host) + strlen(urld->lud_host) + 2); - strcpy(p, urld->lud_host); - strcat(p, " "); - strcat(p, sec->host); - sec->host = p; + sec->host = apr_pstrcat(cmd->pool, urld->lud_host, " ", sec->host, NULL); } else { sec->host = urld->lud_host? apr_pstrdup(cmd->pool, urld->lud_host) : "localhost";