Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Date: Wed, 7 Dec 2005 08:07:56 -0800
From: Justin Erenkrantz <justin@erenkrantz.com>
To: dev@httpd.apache.org
Subject: Re: 2.2 mod_http_proxy and "partial" pages
Message-ID: <20051207160756.GO28636@scotch.ics.uci.edu>
Mail-Followup-To: Justin Erenkrantz <justin@erenkrantz.com>,
	dev@httpd.apache.org
References: 
 <F6E88684A95CDB4DBBD5B9F4C1C4B09B01005CB4@vis01-mx02.vis.internal.vodafone.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <F6E88684A95CDB4DBBD5B9F4C1C4B09B01005CB4@vis01-mx02.vis.internal.vodafone.com>
User-Agent: Mutt/1.5.11

On Wed, Dec 07, 2005 at 10:21:10AM +0100, Plm, Rdiger, VIS wrote:
> I would like to set the c->aborted in mod_proxy's proxy_handler after the
> run_scheme_handler.
> 
> Reason:
> 
> 1. We can define a clear interface for the scheme handlers here:
>    If the backend broke before you sent headers just return BAD_GATEWAY
>    and send nothing, if it broke afterwards just return BROKEN_BACKEND
>    (or whatever you like that should be defined for this case).
>    The proxy handler would handle this BROKEN_BACKEND return code and
>    do the 'right' thing (currently setting c->aborted).
>    Thus we do not have the need to put the burden of the details on
>    the schema handler (why I regard it as a burden see 2.)

Feel free to commit a patch.  =)

> 2. I am not 100% percent happy with the c->aborted approach as the original
>    intention of c->aborted was another one (The connection to the *client* broke
>    not to the *backend*). I admit that I do not see any other approach
>    currently, so we should stick with this, but if we decide to change this
>    later on and we follow 1. then it is much easier to change as we have this
>    code only in *one* location and not in every scheme handler.

But, that's exactly what we want: we must abort the connection to the
client because we can't complete the response.  -- justin