httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Garrett Rooney <roo...@electricjellyfish.net>
Subject Re: [PATCH] mod_proxy_fcgi - send stdin data to fastcgi process
Date Tue, 27 Dec 2005 18:45:08 GMT
On 12/26/05, Paul Querna <chip@force-elite.com> wrote:
> Garrett Rooney wrote:
> > And here we have today's mod_proxy_fcgi patch, support for sending the
> > FASTCGI_STDIN records (which contain the data from the body of the
> > request) to the fastcgi process.  Again, basic testing with a Ruby
> > fastcgi program indicates that it's at least minimally functional
> >
> > Log follows, patch attached.
>
> I do have some issues with this in the long term:
>
> 1) 1024 is tiny. Prolly should try something much higher.

Yah, I just picked an arbitrary buffer size.

> 2) It doesn't check for a reply from the FastCGI backend.  According to
> the spec, a reply can be sent, before STDIN is finished.  This could get
> kinda complicated, but I believe what we should do is Poll the socket
> for both read and write.  When writable, continue a non-blocking write
> to it.  When read able.. hopefully read something from the backend,
> which may again, come before we are done sending STDIN.

See the next patch (to be posted in a few minutes) which converts this
to using apr_poll so it can handle interleaved reading and writing of
records.  Note that it won't yet switch to actual non-blocking
reads/writes, but it will move us in that direction.

> Anyways. These are things we should fix before merging back to trunk,
> but I just committed your patch to the dev branch in r359183.  Its
> progress :)
>
> Thanks Again,

Thanks for committing it!

-garrett

Mime
View raw message