httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: AW: 2.2 mod_http_proxy and "partial" pages
Date Tue, 13 Dec 2005 23:59:15 GMT

On Dec 13, 2005, at 1:28 PM, Ruediger Pluem wrote:
>
> Index: server/core_filters.c
> ===================================================================
> --- server/core_filters.c»······(Revision 356370)
> +++ server/core_filters.c»······(Arbeitskopie)
> @@ -315,8 +315,10 @@
>                                               apr_size_t  
> *bytes_written,
>                                               conn_rec *c);
> ·
> -static void remove_empty_buckets(apr_bucket_brigade *bb);
> +static void detect_error_bucket(apr_bucket *bucket, conn_rec *c);
> ·
> +static void remove_empty_buckets(apr_bucket_brigade *bb, conn_rec  
> *c);
> +

The reason the other patch didn't do this is that,
upon reflection, closing the client connection at
this point does not seem quite right. Closing
it simply because the gateway died just doesn't
feel right, and seems almost overkill. I think
simply setting the error bucket to allow the rest
of the chain to correctly handle it, is the best
we could (and should) do :/
Mime
View raw message