httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r354108 - /httpd/httpd/branches/2.2.x/STATUS
Date Mon, 05 Dec 2005 18:22:53 GMT
Joe Orton wrote:
> On Mon, Dec 05, 2005 at 12:06:15PM -0600, William Rowe wrote:
> 
>>+    BIO_printf(bio, "Certificate version: %ld\n", 
>>X509_get_version(cert)+1);
>>
>>** Cast, here, to long to avoid ambiguity with other versions of this 
>>function.
> 
> There is no cast, X509_get_version() has always returned long, the 
> warning is new because BIO_printf has the gcc printf format string 
> attribute applied in 0.9.8a.  The fix is correct for all versions.

Cool.

>>With this change do we have specific 0.9.6/0.9.7/0.9.8(vanilla) which 
>>will emit errors? 
> 
> No.  It's the same as the equivalent changes made to ssl_scache_*.

thanks for the explanation, +1 :)

Bill

Mime
View raw message