httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r354108 - /httpd/httpd/branches/2.2.x/STATUS
Date Mon, 05 Dec 2005 18:06:15 GMT
jorton@apache.org wrote:
> +    * mod_ssl/ab: Fix compiler warnings with OpenSSL 0.9.8a.
> +        http://svn.apache.org/viewcvs.cgi?rev=349415&view=rev
> +      +1: jorton

+1 with this addendum and query;

@@ -485,7 +485,7 @@
      X509_NAME *dn;
      char buf[1024];

-    BIO_printf(bio, "Certificate version: %d\n", X509_get_version(cert)+1);
+    BIO_printf(bio, "Certificate version: %ld\n", X509_get_version(cert)+1);

** Cast, here, to long to avoid ambiguity with other versions of this function.

--- /httpd/httpd/trunk/modules/ssl/ssl_scache_dc.c	2005/11/28 16:14:55	349414
+++ httpd/httpd/trunk/modules/ssl/ssl_scache_dc.c	2005/11/28 16:16:21	349415
@@ -127,7 +127,7 @@
      unsigned char der[SSL_SESSION_MAX_DER];
      unsigned int der_len;
      SSL_SESSION *pSession;
-    unsigned char *pder = der;
+    MODSSL_D2I_SSL_SESSION_CONST unsigned char *pder = der;

I never saw an error here when I originally fixed, is it specific to 0.9.8a?
With this change do we have specific 0.9.6/0.9.7/0.9.8(vanilla) which will emit
errors?  Check that the constness openssl-version test for
MODSSL_D2I_SSL_SESSION_CONST corresponds to the version in which the affected
function was bumped.  I'm -1 to break older flavors for the latest n' greatest.

Bill

Mime
View raw message