httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: svn commit: r356764 - in /httpd/httpd/branches/2.2.x: CHANGES STATUS modules/proxy/mod_proxy_balancer.c server/protocol.c
Date Fri, 16 Dec 2005 08:33:42 GMT
On Wed, Dec 14, 2005 at 10:05:54AM -0000, niq@apache.org wrote:
> --- httpd/httpd/branches/2.2.x/CHANGES [utf-8] (original)
> +++ httpd/httpd/branches/2.2.x/CHANGES [utf-8] Wed Dec 14 02:05:48 2005
> @@ -16,6 +16,11 @@
>    *) Fix recursive ErrorDocument handling.  PR 36090. 
>       [Chris Darroch <chrisd pearsoncmg.com>]
>  
> +  *) Don't hang on error return from post_read_request.  PR37790 [Nick Kew]
> +
> +  *) Fix off-by-one error in proxy_balancer.  PR37753
> +     [Kazuhiro Osawa <ko yappo ne jp>]
> +
>  Changes with Apache 2.2.0
>  
>    *) mod_negotiation: Minor performance tweak by reusing already calculated
> 

Please only add changes at the top not at the bottom.

> Modified: httpd/httpd/branches/2.2.x/STATUS
> URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/2.2.x/STATUS?rev=356764&r1=356763&r2=356764&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.2.x/STATUS (original)
> +++ httpd/httpd/branches/2.2.x/STATUS Wed Dec 14 02:05:48 2005

I would also prefer that STATUS be updated independently in a separate
commit.

> @@ -82,22 +82,9 @@
>  
>  PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>  
> -    * mod_proxy_balancer: Fix PR37753 (mod_proxy_balancer Stickysession that
> -      uses URL doesn't work)
> -      Trunk version of patch:
> -         http://svn.apache.org/viewcvs.cgi?rev=352010&view=rev
> -      Backport version for 2.2.x of patch:
> -         Trunk version of patch works
> -      +1: rpluem, jerenkrantz, jim
> -
>      * mod_ssl/ab: Fix compiler warnings with OpenSSL 0.9.8a.
>          http://svn.apache.org/viewcvs.cgi?rev=349415&view=rev
>        +1: jorton, jerenkrantz
> -
> -    * core: Die properly if an error occurs in post_read_request
> -      http://svn.apache.org/viewcvs.cgi?rev=354085&view=rev
> -      PR: 37790
> -      +1: niq, jerenkrantz, jim
>  
>      * mod_dbd: When threaded, create a private pool in child_init
>        so we're not using the process pool later.  Also improve

Finally, I'd also prefer that the merges be independent to each approved
change.  Conflating them all in one commit without even noting the trunk
revision in the log message that has been approved (!!) is poor practice.

Thanks.  -- justin

Mime
View raw message