httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r354779 - /httpd/httpd/branches/2.2.x/STATUS
Date Wed, 07 Dec 2005 16:32:32 GMT
Jim Jagielski wrote:
> 
> Justin Erenkrantz wrote:
> > 
> > On Wed, Dec 07, 2005 at 03:48:39PM -0000, jim@apache.org wrote:
> > > +    * proxy_util: Fix case where a shared keepalive connection results in
> > > +      different (and incorrect) workers from being accessed.
> > > +      http://svn.apache.org/viewcvs.cgi/httpd/httpd/trunk/modules/proxy/proxy_util.c?rev=350250&view=diff&r1=350250&r2=332306
> > > +      +1: jim
> > 
> > In reviewing this, I can't for the life of me figure out why there's an if
> > and else check that has the exact same body.  Can't we just do:
> > 
> > if (!conn->hostname || !worker->is_address_reusable ||
> >     (r->connection->keepalives &&
> >      (r->proxyreq == PROXYREQ_PROXY || r->proxyreq == PROXYREQ_REVERSE) &&
> >      (strcasecmp(conn->hostname, uri->hostname) != 0))) {
> >    ....
> > }
> > 
> 
> The sole reason was the keep the present setup, so that if
> is_address_reusable becomes more "accurate" we don't loose
> information on what was the original intent... I'd also
> prefer making it one large conditional as well, but
> others were looking at the current logic and I didn't
> want to change too much :)
> 

PS: Unless add't work is done on this section within the next
    few days, I'll clean up the whole section (in trunk)
    to streamline things... 

-- 
=======================================================================
 Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
           "If you can dodge a wrench, you can dodge a ball."

Mime
View raw message