httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: 2.2 mod_http_proxy and "partial" pages
Date Tue, 06 Dec 2005 17:08:00 GMT
On Tue, Dec 06, 2005 at 09:29:42AM -0500, Brian Akins wrote:
> I have a serious issue.  It seems that if something happens during a 
> proxy request after mod_http_proxy starts reading from the backend 
> server, no error is reported. (IE, see what happens when ap_pass_brigade 
>  returns non success).  The problem is that this "partial page" may be 
> cached because r->status is a cacheable code, but the response is 
> actually "broken."  The result is that the broken version may be cached 
> and served again and again.
> 
> Should we break RFC (maybe) and change r->status to 503 (for example) so 
> cache can check letter.
> 
> Note: this is using our internal mod_cache, but looks like the issue 
> would be the same in stock mod_cache.

Our mod_cache will abort the response if the connection to the original
client is aborted for whatever reason.  So, I'm doubtful the scenario you
describe would happen to our mod_cache.  (See mod_disk_cache.c:1013.)

There *might* be a breakage if the server aborted it's half of the
connection partway through the response.  I don't have the time to fully
look at the code, but there might be a code path that does so.  -- justin

Mime
View raw message