httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r354108 - /httpd/httpd/branches/2.2.x/STATUS
Date Mon, 05 Dec 2005 18:19:53 GMT
On Mon, Dec 05, 2005 at 12:06:15PM -0600, William Rowe wrote:
> jorton@apache.org wrote:
> >+    * mod_ssl/ab: Fix compiler warnings with OpenSSL 0.9.8a.
> >+        http://svn.apache.org/viewcvs.cgi?rev=349415&view=rev
> >+      +1: jorton
> 
> +1 with this addendum and query;
> 
> @@ -485,7 +485,7 @@
>      X509_NAME *dn;
>      char buf[1024];
> 
> -    BIO_printf(bio, "Certificate version: %d\n", X509_get_version(cert)+1);
> +    BIO_printf(bio, "Certificate version: %ld\n", 
> X509_get_version(cert)+1);
> 
> ** Cast, here, to long to avoid ambiguity with other versions of this 
> function.

There is no cast, X509_get_version() has always returned long, the 
warning is new because BIO_printf has the gcc printf format string 
attribute applied in 0.9.8a.  The fix is correct for all versions.

> --- /httpd/httpd/trunk/modules/ssl/ssl_scache_dc.c	2005/11/28 16:14:55 
> 349414
> +++ httpd/httpd/trunk/modules/ssl/ssl_scache_dc.c	2005/11/28 16:16:21 
> 349415
> @@ -127,7 +127,7 @@
>      unsigned char der[SSL_SESSION_MAX_DER];
>      unsigned int der_len;
>      SSL_SESSION *pSession;
> -    unsigned char *pder = der;
> +    MODSSL_D2I_SSL_SESSION_CONST unsigned char *pder = der;
> 
> I never saw an error here when I originally fixed, is it specific to 0.9.8a?

Yes, but you won't see it if you don't build with distcache support 
enabled.

> With this change do we have specific 0.9.6/0.9.7/0.9.8(vanilla) which 
> will emit errors? 

No.  It's the same as the equivalent changes made to ssl_scache_*.

joe

Mime
View raw message