Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: domain of trawick@gmail.com designates
 64.233.162.198 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition;
        b=D0rft5VO1UuL/Qp4/XL2Hw88gJ1KfPdNuiMT5oLsffIy0m3vvJgpwD11g1uwzPoO0gFMwqI+vneJ15cVzfN8DUB2khJJPzXVAo/eCK8Z83LRRw2Knw4zyS+EO/SB6+JNITrtJzZfXwP+I6xMOqdRYJ5O4Y5/WeShYex2N5mvfKQ=
Message-ID: <cc67648e0511130525ua9d676crdfbb073d9db417d2@mail.gmail.com>
Date: Sun, 13 Nov 2005 08:25:42 -0500
From: Jeff Trawick <trawick@gmail.com>
To: dev@apr.apache.org
Subject: apr_wait_for_io_or_timeout() decl in apr_support.h which is in public
 include directory
Cc: dev@httpd.apache.org
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On 11/12/05, Brian Pane <brianp@apache.org> wrote:
> On Nov 11, 2005, at 6:21 PM, Jeff Trawick wrote:
>
> > On 11/11/05, Brad Nicholes <BNICHOLES@novell.com> wrote:
> >>
> >>>>> On 11/11/2005 at 1:40:32 pm, in message
> >> <cc67648e0511111240p479464daq98f668e004e28ec5@mail.gmail.com>, Jeff
> >> Trawick
> >> <trawick@gmail.com> wrote:
> >>> On 11/11/05, Brad Nicholes <BNICHOLES@novell.com> wrote:
> >>>>   Reposting to the APR list with a new subject line.  Does this
> >>>> need
> >> to
> >>>> be taken care of in APR 1.2.x before httpd 2.2 ships?
> >>>
> >>> apr_wait_for_io_or_timeout() is private APR function (not API).  Is
> >>> the caller outside of APR?
> >>
> >> Yes, HTTPD.  trunk/server/core_filters.c
> >
> > Simply shocking ;)  That code needs to be fixed to call a real API :(
>
> I just double-checked the declaration, and apr_wait_for_io_or_timeout()
> currently is implemented as part of the public API.  I don't have any
> strong
> objection to making it private, though (e.g., by wrapping the
> declaration in
> an "#ifdef APR_PRIVATE" or moving apr_support.h to apr/include/arch/
> unix).

apr_support.h has these comments...

/**
 * @defgroup apr_support Internal APR support functions
 * @ingroup APR
 * @{
 */

It must be for pragmatic reasons that apr_support.h is in the apr
include directory instead of include/arch.  Perhaps
include/arch/apr_private_common.h is more appropriate?