Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 32109 invoked from network); 14 Nov 2005 20:59:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 14 Nov 2005 20:59:44 -0000 Received: (qmail 2724 invoked by uid 500); 14 Nov 2005 20:59:43 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 1906 invoked by uid 500); 14 Nov 2005 20:59:41 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 1894 invoked by uid 99); 14 Nov 2005 20:59:41 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Nov 2005 12:59:41 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [209.133.199.10] (HELO jimsys.jagunet.com) (209.133.199.10) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Nov 2005 12:59:32 -0800 Received: from [127.0.0.1] (localhost [127.0.0.1]) by jimsys.jagunet.com (Postfix) with ESMTP id CE9D27AC439 for ; Mon, 14 Nov 2005 15:59:19 -0500 (EST) Mime-Version: 1.0 (Apple Message framework v746.2) In-Reply-To: <4378F8DA.50405@apache.org> References: <200511131622.jADGMCm24413@devsys.jaguNET.com> <5DD16129-F43A-4C76-AA01-1AF62DF510FB@jaguNET.com> <4378F8DA.50405@apache.org> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <96454900-91FB-4B57-AEF8-3569BCF19209@jaguNET.com> Content-Transfer-Encoding: 7bit From: Jim Jagielski Subject: Re: ap_get_server_port differences Date: Mon, 14 Nov 2005 15:59:19 -0500 To: dev@httpd.apache.org X-Mailer: Apple Mail (2.746.2) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On Nov 14, 2005, at 3:51 PM, Ruediger Pluem wrote: > > > On 11/14/2005 03:49 PM, Jim Jagielski wrote: >> I am thinking about something like the below: > > As far as I understand the patch the default value will be > UseCanonicalPhysicalPort off which is the 2.0 behaviour, correct? > > If yes, +1 from my side. > > This leaves only open the inconsistency between ap_get_server_name > and ap_get_server_port if UNC is not set at all > (ap_get_server_name behaves like UNC off whereas ap_get_server_port > behaves like UNC on if UNC isn't set at all) . > Yes, the _UNSET usage is very inconsistent, but it's something that's been inherited from older versions :) I think that either: 1. _UNSET should be removed or 2. _UNSET should be considered _OFF My pers. pref is #1... Again, it's these types of cleanups that should be done now ;)