Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: domain of xuekun.hu@gmail.com designates
 64.233.162.199 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=pQfEtYZvlR8e7m/FQ6+YccaE4JXwFE2GcuD6CvFs/DNV6xRnwvITMU8n9lJ3o3pOY+EHqaZEbKXokaNoYe+l2/0YpxbBzmOcPk0Z5FX6GDb5OyVgzaxOK2yKRDw9zbUnosFlFowPC+/HGpDdvrx4+OEd2BLY9OQdA0AdqfM/rmw=
Message-ID: <398d69300511040017t5af86450ub8d35888fa1935d@mail.gmail.com>
Date: Fri, 4 Nov 2005 16:17:20 +0800
From: Xuekun Hu <xuekun.hu@gmail.com>
To: dev@httpd.apache.org, bill@wstoddard.com
Subject: Re: Potential memory leak in /modules/cache/mod_mem_cache.c
In-Reply-To: <436933DE.6030307@wstoddard.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <dkb9eh$ue$1@sea.gmane.org> <436933DE.6030307@wstoddard.com>

So, same reason. Also in file mod_mem_cache.c around line 786, there
is a malloc(mobj->m_len), and a few lines later, another
malloc(obj->count) is performed.

If the second malloc fails, I think also should add something like
  free(mobj->m);
  mobj->m =3D NULL;

reasonable?

Thx, Xuekun

On 11/3/05, Bill Stoddard <bill@wstoddard.com> wrote:
> Christophe Jaillet wrote:
> > Comments agains httpd-2.1.8-beta
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >
> > In file mod_mem_cache.c (/modules/cache) around line 558, there is a ma=
lloc
> > (*obj).
> > A few lines later, another malloc (buf) is performed.
> >
> > If the second malloc fails, then we have (*obj =3D NULL) but I don't se=
e
> > anyway to free the memory allocated.
> > I would have imagined something like
> > free (*obj);
> > *obj =3D NULL;
> >
> > Unless, as a newbie in apache, there is something I don't know about me=
mory
> > management in apache...
> >
> > Christophe JAILLET
> >
>
> Agreed, looks like a bug and your fix looks right.
>
> Bill
>
>