Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
From: Jim Jagielski <jim@jaguNET.com>
Message-Id: <200511011508.jA1F84w07592@devsys.jaguNET.com>
Subject: Re: svn commit: r329849 - in /httpd/httpd/trunk: CHANGES
 modules/proxy/proxy_util.c
To: dev@httpd.apache.org
Date: Tue, 1 Nov 2005 10:08:00 -0500 (EST)
Reply-To: jim@jaguNET.com
In-Reply-To: <no.id> from "Roy T. Fielding" at Nov 01, 2005 07:04:35 AM
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Roy T. Fielding wrote:
> 
> >     c = ap_strchr_c(url, ':');
> >     if (c == NULL || c[1] != '/' || c[2] != '/' || c[3] == '\0')
> >        return NULL;
> 
> BTW, unless url is somehow limited to http and ftp, the above
> is bad code.  The proxy should be able to handle arbitrary
> schemes (eventually), which means requiring scheme://host
> is bogus.
> 

The current code does make that restriction, but yes, it may be too
limiting... Of course, this means that the workers would also
need to be not so restricted as well :)

-- 
=======================================================================
 Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
           "If you can dodge a wrench, you can dodge a ball."