httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: ap_get_server_port differences
Date Mon, 14 Nov 2005 20:59:19 GMT

On Nov 14, 2005, at 3:51 PM, Ruediger Pluem wrote:

>
>
> On 11/14/2005 03:49 PM, Jim Jagielski wrote:
>> I am thinking about something like the below:
>
> As far as I understand the patch the default value will be  
> UseCanonicalPhysicalPort off which is the 2.0 behaviour, correct?
>
> If yes, +1 from my side.
>
> This leaves only open the inconsistency between ap_get_server_name  
> and ap_get_server_port if UNC is not set at all
> (ap_get_server_name behaves like UNC off whereas ap_get_server_port  
> behaves like UNC on if UNC isn't set at all) .
>

Yes, the _UNSET usage is very inconsistent, but it's something
that's been inherited from older versions :)

I think that either:

    1. _UNSET should be removed
            or
    2. _UNSET should be considered _OFF

My pers. pref is #1... Again, it's these types of cleanups
that should be done now ;)

Mime
View raw message