httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] Broken APR_CHECK_APR_DEFINE() macro in test for APR_HAVE_IPV6 and APR_HAS_RANDOM
Date Wed, 02 Nov 2005 12:43:42 GMT
On Wed, Nov 02, 2005 at 01:31:23PM +0100, Martin Kraemer wrote:
> Using a replacement from $() to ${} plus using a second eval to expand
> the ${top_builddir} fixes it, but that is IMHO an utterly ugly hack.
> (Also, it introduces several other problems if shell special characters
> appear in paths)
> 
> Suggestions welcome: how can the configure script be fixed in a clean
> way?

Converting all use of $() when adding to INCLUDES in configure to ${} so 
the paths get expanded immediately would seem like the best fix unless 
there's some reason why that won't work (I can't think of any).  
config_vars.sh might need updating to strip the expanded paths properly 
during installation.

joe

Mime
View raw message