httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r329849 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c
Date Tue, 01 Nov 2005 15:08:00 GMT
Roy T. Fielding wrote:
> 
> >     c = ap_strchr_c(url, ':');
> >     if (c == NULL || c[1] != '/' || c[2] != '/' || c[3] == '\0')
> >        return NULL;
> 
> BTW, unless url is somehow limited to http and ftp, the above
> is bad code.  The proxy should be able to handle arbitrary
> schemes (eventually), which means requiring scheme://host
> is bogus.
> 

The current code does make that restriction, but yes, it may be too
limiting... Of course, this means that the workers would also
need to be not so restricted as well :)

-- 
=======================================================================
 Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
           "If you can dodge a wrench, you can dodge a ball."

Mime
View raw message