Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: domain of jorton@redhat.com designates
 66.187.233.31 as permitted sender)
Date: Mon, 3 Oct 2005 12:58:45 +0100
From: Joe Orton <jorton@redhat.com>
To: dev@httpd.apache.org
Subject: Re: svn commit: r293305 - in /httpd/httpd/branches/2.2.x/modules:
 dav/fs/dbm.c
Message-ID: <20051003115845.GF6219@redhat.com>
Mail-Followup-To: dev@httpd.apache.org
References: <200510031150.j93Boh700945@devsys.jaguNET.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <200510031150.j93Boh700945@devsys.jaguNET.com>
User-Agent: Mutt/1.4.2.1i

On Mon, Oct 03, 2005 at 07:50:39AM -0400, Jim Jagielski wrote:
> Just some lines that caught my eye:
> 
> >  
> > -    *context = (void *)(value == 'T');
> > +    *context = (void *)((long)(value == 'T'));
> >  
> > -    int value = context != NULL;
> > +    long value = context != NULL;
> >      apr_fileperms_t perms = resource->info->finfo.protection;
> > -    int old_value = (perms & APR_UEXECUTE) != 0;
> > +    long old_value = (perms & APR_UEXECUTE) != 0;
> >  
> 
> Huh? Whenever I see conditionals cast to (long) I get
> suspicious. 

These are all cases where an integer is stored in a pointer; it's safe 
to assume that a long will fit in a pointer on all platforms which httpd 
runs on as a practical consideration, and using a cast to long rather 
than a cast to int will avoid compiler warnings on LP64 platforms.

joe