Return-Path: 
 <dev-return-49533-apmail-httpd-dev-archive=httpd.apache.org@httpd.apache.org>
Delivered-To: apmail-httpd-dev-archive@www.apache.org
Received: (qmail 50162 invoked from network); 3 Oct 2005 12:47:09 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 3 Oct 2005 12:47:09 -0000
Received: (qmail 56311 invoked by uid 500); 3 Oct 2005 12:47:06 -0000
Delivered-To: apmail-httpd-dev-archive@httpd.apache.org
Received: (qmail 55829 invoked by uid 500); 3 Oct 2005 12:47:04 -0000
Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
list-help: <mailto:dev-help@httpd.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@httpd.apache.org>
List-Post: <mailto:dev@httpd.apache.org>
List-Id: <dev.httpd.apache.org>
Delivered-To: mailing list dev@httpd.apache.org
Received: (qmail 55818 invoked by uid 99); 3 Oct 2005 12:47:04 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Oct 2005 05:47:04 -0700
X-ASF-Spam-Status: No, hits=0.1 required=10.0
	tests=FORGED_RCVD_HELO
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Received: from [81.95.104.4] (HELO mail.active24.cz) (81.95.104.4)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Oct 2005 05:47:09 -0700
Received: from maple.active24.cz (maple.office.active24.cz [81.95.104.250])
	by mail.active24.cz (Postfix) with ESMTP id D9C3428000AF
	for <dev@httpd.apache.org>; Mon,  3 Oct 2005 14:53:07 +0200 (CEST)
Subject: Re: Pluggable mod_log_config
From: Ondrej Sury <ondrej@sury.org>
To: dev@httpd.apache.org
In-Reply-To: <43411D01.8050203@turner.com>
References: <1128277162.9430.8.camel@localhost.localdomain>
	 <43411D01.8050203@turner.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="=-sqMVY7t9iNJxzHYA/7yo"
Date: Mon, 03 Oct 2005 14:46:58 +0200
Message-Id: <1128343618.9474.37.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.4.0 
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N


--=-sqMVY7t9iNJxzHYA/7yo
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, 2005-10-03 at 07:58 -0400, Brian Akins wrote:
>=20
> mod_log_config is "pluggable."   You can "replace" the normal logging=20
> functions quite easily.

The word here is _replace_.  If you "replace" ap_log_writer and
ap_log_writer_init you need to implement all types of logging inside
ap_log_writer.

Imagine this type of config:
--cut here--
<VirtualHost 1.2.3.4>
  [...]
  CustomLog mysql://blah/data common

</VirtualHost>

<VirtualHost 1.2.3.5>
  [...]
  CustomLog $apache#1 combined # mod_log_spread syntax

</VirtualHost>

<VirtualHost 1.2.3.6>
  [...]
  CustomLog /var/log/apache2/access.log

</VirtualHost>
--cut here--

Then your replacement function would have to implement all those types
of log backends (ie. logging to mysql, spread, and files).  So you
cannot just easily add support for just another log backend.

Even now when you want to make some log files buffered and some not you
are out of luck and this could also be solved by making plugging more
"general".

Ondrej.
--=20
Ondrej Sury <ondrej@sury.org>

--=-sqMVY7t9iNJxzHYA/7yo
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQBDQShC9OZqfMIN8nMRApi2AJ9siAz2f7pkx0vmgd9yhh764KdOvACcC8S+
oRwiJxeImZZrdj03cCpTwDo=
=as84
-----END PGP SIGNATURE-----

--=-sqMVY7t9iNJxzHYA/7yo--