httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Roy T. Fielding <field...@gbiv.com>
Subject [PATCH] remove block on OPTIONS from mod_cgi
Date Sat, 15 Oct 2005 19:40:59 GMT
I objected to this code when it was first added (13 Aug 1996)
as part of Alexei's huge HTTP/1.1 patch and for some unknown
reason I forgot to remove it.

<http://mail-archives.apache.org/mod_mbox/httpd-dev/199608.mbox/ 
%3c9608132318.aa12603@paris.ics.uci.edu%3e>

It has been featured in multiple PRs since then for both GNATS (4490)
and Bugzilla (PR 15242).  Are there any objections to removing it now,
both here and in mod_cgid?  It is currently preventing folks from
implementing new services (WEBDAV and Atom, among others) via CGI.

....Roy


Index: mod_cgi.c
===================================================================
--- mod_cgi.c   (revision 321466)
+++ mod_cgi.c   (working copy)
@@ -756,13 +756,6 @@

      p = r->main ? r->main->pool : r->pool;

-    if (r->method_number == M_OPTIONS) {
-        /* 99 out of 100 CGI scripts, this is all they support */
-        r->allowed |= (AP_METHOD_BIT << M_GET);
-        r->allowed |= (AP_METHOD_BIT << M_POST);
-        return DECLINED;
-    }
-
      argv0 = apr_filepath_name_get(r->filename);
      nph = !(strncmp(argv0, "nph-", 4));
      conf = ap_get_module_config(r->server->module_config, &cgi_module);


Mime
View raw message